Michael Smith has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20311 )

Change subject: IMPALA-12334: Add debug symbols to LLVM assert build
......................................................................

IMPALA-12334: Add debug symbols to LLVM assert build

Builds the LLVM debug build (-asserts) with -g1 so we get reasonable
stack traces in LLVM while debugging Impala.

Excludes building some parts of LLVM, similar to what Kudu does in
https://github.com/apache/kudu/blob/master/thirdparty/build-definitions.sh.

Strips binaries we don't link against at runtime as the goal is to debug
Impala's use of LLVM, not LLVM itself.

These changes shrink the non-assert LLVM build by ~100 MB, and keep the
assert build around the same size. Using RelWithDebInfo increases the
size from ~350MB to 1GB.

Change-Id: I9c58bfe2233dcec39fcad92fc52ce372165229d8
Reviewed-on: http://gerrit.cloudera.org:8080/20311
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Michael Smith <[email protected]>
---
M source/llvm/build-source-tarball.sh
1 file changed, 90 insertions(+), 1 deletion(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Michael Smith: Verified

--
To view, visit http://gerrit.cloudera.org:8080/20311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c58bfe2233dcec39fcad92fc52ce372165229d8
Gerrit-Change-Number: 20311
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>

Reply via email to