Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 )
Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline ...................................................................... Patch Set 1: (2 comments) As you add more functionalities to this script, you may move some functions to separate script files to keep file size in reasonable size. You also need to add some unit-test. Otherwise we have to run tests for each function manually for each version of patch. There is no testing framework for Javascript in Impala. You need to bring in one testing framework. http://gerrit.cloudera.org:8080/#/c/20355/1/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20355/1/www/query_timeline.tmpl@499 PS1, Line 499: try { parentElement.removeChild(childElement); } : catch(e) {} nit: break to multiple lines http://gerrit.cloudera.org:8080/#/c/20355/1/www/query_timeline.tmpl@629 PS1, Line 629: fragment_metrics_chart.load({ : unload : true : }); nit: don't need to break to multiple lines -- To view, visit http://gerrit.cloudera.org:8080/20355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd25e6f0bc9fbd664ec98936daff3f27182dfc7f Gerrit-Change-Number: 20355 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Aug 2023 21:44:37 +0000 Gerrit-HasComments: Yes
