Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 )
Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20355/2/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20355/2/www/query_timeline.tmpl@65 PS2, Line 65: <input type="checkbox" id="plan_order" onClick="renderFragmentDiagram()"/> > Yes. I was planning to do it in the subsequent patch set and have done it. It's a little strange that you can close the periodic chart and there is no way to get it back except re-load but it won't hurt to leave it this way. http://gerrit.cloudera.org:8080/#/c/20355/2/www/query_timeline.tmpl@471 PS2, Line 471: - (fragment_id_selected == undefined? 0 : getFragmentMetricsHeight()) > Probably better to show fragment metric after periodic metrics so the perio Are you planning to address this? http://gerrit.cloudera.org:8080/#/c/20355/2/www/query_timeline.tmpl@778 PS2, Line 778: width : diagram_width The tics/scaling for the fragment metrics are not aligned properly now. http://gerrit.cloudera.org:8080/#/c/20355/2/www/query_timeline.tmpl@1018 PS2, Line 1018: clearTimesamples(sampled_utilization_timeseries, max_samples_utilization); > Can we aggregate the fragment metrics into the periodic metrics too? Are you planning to address this? http://gerrit.cloudera.org:8080/#/c/20355/2/www/query_timeline.tmpl@1106 PS2, Line 1106: timestamp_gridline = get_svg_line(stroke_fill_colors.black, e.pageX, 0, e.pageX, > can we make this so the cursors on all charts move together? This seems to be implemented now. -- To view, visit http://gerrit.cloudera.org:8080/20355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd25e6f0bc9fbd664ec98936daff3f27182dfc7f Gerrit-Change-Number: 20355 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Aug 2023 21:23:52 +0000 Gerrit-HasComments: Yes
