Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 )
Change subject: IMPALA-10798: Prototype a simple JSON File reader ...................................................................... Patch Set 22: (1 comment) Thank you once again for the code review. I have been a little busy lately, but I managed to find some time to complete the move of json-parser.h and separate the implementation into json-parser.cc. As for the remaining task of adding new test cases, I will try to find another time to finish it. http://gerrit.cloudera.org:8080/#/c/19699/22/be/src/exec/json-parser.h File be/src/exec/json-parser.h: http://gerrit.cloudera.org:8080/#/c/19699/22/be/src/exec/json-parser.h@37 PS22, Line 37: > It seems to be tightly coupled with hdfs-json-scanner so I think we > can put it in /json unless it can be reused in other places. > > Moving the implementation codes to json-parser.cc helps to speedup > recompilation when you have code changes. Also helps to make this > header file shorter and easier for going through. You can keep some > short methods in the header file and just move large methods like > Parse(). Done, It could compiles successfully in my own environment, but I'm not sure why it keeps failing to build here. -- To view, visit http://gerrit.cloudera.org:8080/19699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31309cb8f2d04722a0508b3f9b8f1532ad49a569 Gerrit-Change-Number: 19699 Gerrit-PatchSet: 22 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 18 Aug 2023 09:51:08 +0000 Gerrit-HasComments: Yes
