Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 )
Change subject: IMPALA-10798: Prototype a simple JSON File reader ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/19699/26//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19699/26//COMMIT_MSG@7 PS26, Line 7: Prototype a simple JSON File reader Let's change the title to something like "Initial support for reading JSON files" http://gerrit.cloudera.org:8080/#/c/19699/22/be/src/exec/json-parser.h File be/src/exec/json-parser.h: http://gerrit.cloudera.org:8080/#/c/19699/22/be/src/exec/json-parser.h@37 PS22, Line 37: > > It seems to be tightly coupled with hdfs-json-scanner so I think we I took a look. The failed job is https://jenkins.impala.io/job/clang-tidy-ub2004/99/console It fails in running bin/run_clang_tidy.sh. There are some errors in the output file: https://jenkins.impala.io/job/clang-tidy-ub2004/99/artifact/tidylog.txt E.g. one of the error: /home/ubuntu/Impala/be/src/exec/json/json-parser.cc:233:16: error: explicit instantiation of 'impala::JsonParser' must occur in namespace 'impala' template class JsonParser<SimpleJsonScanner>; ^ -- To view, visit http://gerrit.cloudera.org:8080/19699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31309cb8f2d04722a0508b3f9b8f1532ad49a569 Gerrit-Change-Number: 19699 Gerrit-PatchSet: 26 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 21 Aug 2023 01:07:03 +0000 Gerrit-HasComments: Yes
