Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/19517/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/8//COMMIT_MSG@14 PS8, Line 14: t Nit: typo, 'specific'. http://gerrit.cloudera.org:8080/#/c/19517/8//COMMIT_MSG@23 PS8, Line 23: - Added test to make sure "Impala Query State" is populated. Could you clarify this? Are these two separate items or one? It could be for example "Added a test to make sure "Impala Query State" is populated when running a query that fails with AnalysisException". -- To view, visit http://gerrit.cloudera.org:8080/19517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 8 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 11:45:18 +0000 Gerrit-HasComments: Yes
