Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 )
Change subject: IMPALA-12399: Pass eventTypeSkipList with OPEN_TXN in NotificationEventRequest to avoid receiving OPEN_TXN events from HMS ...................................................................... Patch Set 3: Code-Review+1 (2 comments) This is a nice improvement! Just have some minor comments. I can bump it to +2 when they are resolved. http://gerrit.cloudera.org:8080/#/c/20427/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20427/3//COMMIT_MSG@7 PS3, Line 7: Pass eventTypeSkipList with OPEN_TXN in NotificationEventRequest : to avoid receiving OPEN_TXN events from HMS nit: Maybe we can make this shorter like "Add filter to skip OPEN_TXN events from HMS" http://gerrit.cloudera.org:8080/#/c/20427/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20427/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@269 PS3, Line 269: eventSkipList nit: The code style prefers uppercase names for static final fields. Or we can simply move this into MetastoreShim of CDP Hive3 since it's only used there. -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 30 Aug 2023 00:51:20 +0000 Gerrit-HasComments: Yes
