[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 )
Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS ...................................................................... Patch Set 6: (2 comments) Reworked comments http://gerrit.cloudera.org:8080/#/c/20427/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20427/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@269 PS3, Line 269: EVENT_SKIP_LI > nit: The code style prefers uppercase names for static final fields. Done http://gerrit.cloudera.org:8080/#/c/20427/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20427/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@269 PS4, Line 269: private static final List<String> EVENT_SKIP_LIST = Arrays.asList("OPEN_TXN"); > Can add a test in added -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 06 Sep 2023 12:25:28 +0000 Gerrit-HasComments: Yes
