Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 )
Change subject: IMPALA-12385: Enable Periodic metrics by default ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20377/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20377/5//COMMIT_MSG@15 PS5, Line 15: -Reduced profile metric samping interval to 50ms to support short-running : queries. > Done Done http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/runtime-profile.h@156 PS5, Line 156: bool is_system_; > I actually missed some counters that were instantiated through macros. So K nit: I still think that this can be removed because RuntimeProfile::Counter is separate from RuntimeProfile::TimeSeriesCounter. TotalBytesDequeued and TotalBytesReceived in KRPC code are TimeSeriesCounter and not Counter. -- To view, visit http://gerrit.cloudera.org:8080/20377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1 Gerrit-Change-Number: 20377 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 31 Aug 2023 18:32:19 +0000 Gerrit-HasComments: Yes
