Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 )
Change subject: IMPALA-12385: Enable Periodic metrics by default ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG@12 PS1, Line 12: resource_trace_ratio to 1 > https://issues.apache.org/jira/browse/IMPALA-7694 seems to posit that it mi Riza had the same concern so I did additional testing. We will re-visit if any problems are observed. http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG@13 PS1, Line 13: -Use samplng counters which can automatically resize for long queries > nit: type in samplng Done http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG@14 PS1, Line 14: -Reduce metric interval to 50ms to support short-running queries > Can you add an example of how this shows up in a Profile? Done http://gerrit.cloudera.org:8080/#/c/20377/6/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/20377/6/be/src/util/runtime-profile-counters.h@822 PS6, Line 822: }; > nit: this formatting doesn't seem consistent with our usual style. Done http://gerrit.cloudera.org:8080/#/c/20377/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/20377/6/tests/query_test/test_observability.py@549 PS6, Line 549: # We check for 500ms because a query with 1s duration won't hit the 64 values limit > Comment should say 50ms now. Done -- To view, visit http://gerrit.cloudera.org:8080/20377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1 Gerrit-Change-Number: 20377 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Sat, 09 Sep 2023 12:10:08 +0000 Gerrit-HasComments: Yes
