Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20474
Change subject: IMPALA-12411: Fix data race in expr-test teardown ...................................................................... IMPALA-12411: Fix data race in expr-test teardown TSAN ThreadSanitizer detected a data race during expr-test teardown. It happened because ImpaladQueryExecutor closes the previous query when you start the next query and it relies on the destructor to close the last query. expr-test creates ImpaladQueryExecutor as a global as part of setting up an in-memory cluster (with Statestore and InProcessImpalaServer). So the last query isn't guaranteed to be closed until global destruction, which leads to a race with other global destruction (in this case the JvmMetricCache, which is used when updating QueryState on query completion). This only impacts expr-test as that's the only place ImpaladQueryExecutor is used. Change-Id: I8e289b292cb11154f1245e2b987cde0995b6243c --- M be/src/exprs/expr-test.cc 1 file changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20474/1 -- To view, visit http://gerrit.cloudera.org:8080/20474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8e289b292cb11154f1245e2b987cde0995b6243c Gerrit-Change-Number: 20474 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]>
