Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20494/1/be/src/runtime/bufferpool/buffer-allocator.h File be/src/runtime/bufferpool/buffer-allocator.h: http://gerrit.cloudera.org:8080/#/c/20494/1/be/src/runtime/bufferpool/buffer-allocator.h@195 PS1, Line 195: int64_t SumOverArenas(const std::function<int64_t(FreeBufferArena* arena)>& compute_fn) const; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20494/1/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20494/1/be/src/scheduling/cluster-membership-mgr.cc@99 PS1, Line 99: const ClusterMembershipMgr::SnapshotPtr& snapshot) { this->UpdateMetrics(snapshot); }); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 19 Sep 2023 21:56:04 +0000 Gerrit-HasComments: Yes
