Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20500 )
Change subject: IMPALA-8675: Remove db/table count metrics from impalad in LocalCatalog mode ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20500/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20500/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1067 PS2, Line 1067: } > Do we need to call FeCatalogUtils.populateCacheMetrics() for non local cata It's a no-op for the legacy catalog mode. We can move it into the first if-branch. -- To view, visit http://gerrit.cloudera.org:8080/20500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02a409b7b24577f75d7c439c85bc3491ec7c518c Gerrit-Change-Number: 20500 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 03:41:37 +0000 Gerrit-HasComments: Yes
