Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20500 )

Change subject: IMPALA-8675: Remove db/table count metrics from impalad in 
LocalCatalog mode
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20500/2/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java:

http://gerrit.cloudera.org:8080/#/c/20500/2/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@481
PS2, Line 481: cacheEntrySize.getMedian()
median size was affected when setting resp.num_dbs = -1 and
resp.num_tables = -1


http://gerrit.cloudera.org:8080/#/c/20500/3/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/20500/3/tests/custom_cluster/test_local_catalog.py@520
PS3, Line 520: 1000
this test failed. Should change cache_entry_median_size < 3000



--
To view, visit http://gerrit.cloudera.org:8080/20500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a409b7b24577f75d7c439c85bc3491ec7c518c
Gerrit-Change-Number: 20500
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 21 Sep 2023 19:49:55 +0000
Gerrit-HasComments: Yes

Reply via email to