Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20494/2/be/src/rpc/thrift-thread.cc File be/src/rpc/thrift-thread.cc: http://gerrit.cloudera.org:8080/#/c/20494/2/be/src/rpc/thrift-thread.cc@70 PS2, Line 70: // Passing runnable in to this method (rather than reading from this->runnable()) > Based on the Notes at https://en.cppreference.com/w/cpp/utility/functional/ I've tried it with a small test file and I think you're right, std::bind seems to keep a copy of the shared_ptr and increment its counter. But it's not easy to see, so I think we should explain it in a comment at least. http://gerrit.cloudera.org:8080/#/c/20494/2/be/src/runtime/io/disk-io-mgr-test.cc File be/src/runtime/io/disk-io-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/20494/2/be/src/runtime/io/disk-io-mgr-test.cc@720 PS2, Line 720: sub_ranges > sub_ranges is called in a loop, we need to make a copy each call. Right, thanks. -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2023 15:27:33 +0000 Gerrit-HasComments: Yes
