Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20507 )
Change subject: IMPALA-12460: Add lag and histogram of event processing in the log ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20507/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20507/4//COMMIT_MSG@28 PS4, Line 28: jstacks. adding automatic tests would be nice in the long run http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@503 PS4, Line 503: dbName_ maybe add "DB_WIDE "? http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@947 PS4, Line 947: lastSyncedEventTime shouldn't we print a warning only above some trashold? -- To view, visit http://gerrit.cloudera.org:8080/20507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9421b5e26bfa2324217ec9695fbd81636727d22 Gerrit-Change-Number: 20507 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2023 14:06:49 +0000 Gerrit-HasComments: Yes
