Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20507 )
Change subject: IMPALA-12460: Add lag and histogram of event processing in the log ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1075 PS4, Line 1075: eventProcessingTime.put(event, elapsedTimeMs); > This can override the last maximum value. Sorry, I don't get the point. The keys are different event objects. How can they override each other? http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1121 PS4, Line 1121: targetLis > nit: targetList Done -- To view, visit http://gerrit.cloudera.org:8080/20507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9421b5e26bfa2324217ec9695fbd81636727d22 Gerrit-Change-Number: 20507 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 26 Sep 2023 02:06:01 +0000 Gerrit-HasComments: Yes
