Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20515 )
Change subject: IMPALA-12243: Add support for DROP PARTITION for Iceberg tables ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20515/1/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/20515/1/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@277 PS1, Line 277: numericLiteral -> inPredicate.getChildren().set(affectedChildId, numericLiteral)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20515/1/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpr.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpr.java: http://gerrit.cloudera.org:8080/#/c/20515/1/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpr.java@170 PS1, Line 170: protected void toThrift(TExprNode msg) { /*Keeping it empty to avoid constant folding */ } line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a768ba2966f570454687e02e4e6d67df46741f9 Gerrit-Change-Number: 20515 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2023 07:14:45 +0000 Gerrit-HasComments: Yes
