Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20515 )
Change subject: IMPALA-12243: Add support for DROP PARTITION for Iceberg tables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20515/3/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java File fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java: http://gerrit.cloudera.org:8080/#/c/20515/3/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java@212 PS3, Line 212: protected BigDecimal getIcebergDecimalValue(IcebergColumn column, NumericLiteral literal) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20515/3/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java@230 PS3, Line 230: protected Long getIcebergTsValue(LiteralExpr literal, IcebergColumn column, Schema iceSchema) line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a768ba2966f570454687e02e4e6d67df46741f9 Gerrit-Change-Number: 20515 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2023 08:33:56 +0000 Gerrit-HasComments: Yes
