Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 )
Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads ...................................................................... Patch Set 4: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/20523/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20523/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@378 PS3, Line 378: // Using a single-element array to make the Java compiler happy. Otherwise it > Nit: "element" Done http://gerrit.cloudera.org:8080/#/c/20523/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@384 PS3, Line 384: // thread, so the updates to dataFilesCacheMisses and the other objects will not be > Maybe add: Yes, added the extra comment. -- To view, visit http://gerrit.cloudera.org:8080/20523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00db941dd5ac9917cd91d990fccf37e5bcfddbfc Gerrit-Change-Number: 20523 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2023 18:51:24 +0000 Gerrit-HasComments: Yes
