Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 )
Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20523/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20523/4//COMMIT_MSG@14 PS4, Line 14: : The forEach() spreads the work across multiple threads. nit: Is this code from iceberg library responsible for the parallel work? https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/util/ParallelIterable.java If yes, can we mention ParallelIterable.java somewhere in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/20523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00db941dd5ac9917cd91d990fccf37e5bcfddbfc Gerrit-Change-Number: 20523 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2023 23:35:43 +0000 Gerrit-HasComments: Yes
