Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Partial unicode column name support ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20506/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/20506/2/be/src/runtime/coordinator.cc@1172 PS2, Line 1172: RPCErrorInfoPB rpc_error_info = aux_error.rpc_error_info(); > It's resolved now. It was due to a faulty rebase. Done http://gerrit.cloudera.org:8080/#/c/20506/2/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: http://gerrit.cloudera.org:8080/#/c/20506/2/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java@207 PS2, Line 207: throw new AnalysisException("Invalid column/field name: " + colName_); > I've updated the commit message, kindly let me know if it requires any furt It seems much clearer to me now, thanks. -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2023 17:44:02 +0000 Gerrit-HasComments: Yes
