Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Partial unicode column name support ...................................................................... Patch Set 3: (6 comments) Thanks. http://gerrit.cloudera.org:8080/#/c/20506/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20506/3//COMMIT_MSG@7 PS3, Line 7: Partial Why is it partial? The fact that it's only for column names is already included in the title. Are there character sets that we don't support? http://gerrit.cloudera.org:8080/#/c/20506/3//COMMIT_MSG@9 PS3, Line 9: hive Nit: capitalise Hive. http://gerrit.cloudera.org:8080/#/c/20506/3//COMMIT_MSG@11 PS3, Line 11: hive Nit: capitalise Hive. http://gerrit.cloudera.org:8080/#/c/20506/3//COMMIT_MSG@15 PS3, Line 15: allows 'Allows' sounds strange here, with respect to restrictions, it could be something else like 'places no restriction. http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@946 PS3, Line 946: Column Names Nit: 'column names' does not need to be capitalised. http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@959 PS3, Line 959: Column Names Nit: 'column names' does not need to be capitalised. -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 16 Oct 2023 14:40:10 +0000 Gerrit-HasComments: Yes
