Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20519 )
Change subject: IMPALA-12354: Add aarch64 native-toolchain build ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/20519/8/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/20519/8/bin/impala-config.sh@104 PS8, Line 104: if [[ "${TOOLCHAIN_ARCH}" = aarch64 ]]; then Actually I think this is worse. It's more complicated and error-prone to implement in shell, and takes the selection further from where it's used which means I forgot to skip it when NATIVE_TOOLCHAIN_HOME is set which would be the actual override). -- To view, visit http://gerrit.cloudera.org:8080/20519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bfa7125dbc647b33041c5572d97b7f7ccad6258 Gerrit-Change-Number: 20519 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2023 16:59:09 +0000 Gerrit-HasComments: Yes
