Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20519 )

Change subject: IMPALA-12354: Add aarch64 native-toolchain build
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20519/10/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/20519/10/bin/bootstrap_toolchain.py@256
PS10, Line 256:     # Most common return values for machine are x86_64 or 
aarch64
              :     arch = platform.machine()
              :     if arch not in ['aarch64', 'x86_64']:
              :       raise Exception("Unsupported architecture '{}' for 
pre-built native-toolchain. "
              :           "Fetch and build it locally by setting 
NATIVE_TOOLCHAIN_HOME".format(arch))
              :     toolchain_build_id = 
os.environ["IMPALA_TOOLCHAIN_BUILD_ID_{}".format(arch.upper())]
> I see we are using a different build number per arch, but the toolchain als
Done



--
To view, visit http://gerrit.cloudera.org:8080/20519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bfa7125dbc647b33041c5572d97b7f7ccad6258
Gerrit-Change-Number: 20519
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 12 Oct 2023 04:21:50 +0000
Gerrit-HasComments: Yes

Reply via email to