Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20507 )

Change subject: IMPALA-12460: Add lag and histogram of event processing in the 
log
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20507/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File 
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:

http://gerrit.cloudera.org:8080/#/c/20507/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1105
PS6, Line 1105:     for (int i = 0; i < num; ++i) {
> Can we use a range-based FOR loop here?
Done


http://gerrit.cloudera.org:8080/#/c/20507/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1125
PS6, Line 1125:     for (int i = 0; i < num; ++i) {
> Can we use a range-based FOR loop here?
Done



--
To view, visit http://gerrit.cloudera.org:8080/20507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9421b5e26bfa2324217ec9695fbd81636727d22
Gerrit-Change-Number: 20507
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 09 Oct 2023 02:48:49 +0000
Gerrit-HasComments: Yes

Reply via email to