Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 )
Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI ...................................................................... Patch Set 1: (5 comments) Sure. Once this patch is merged, I will update the wiki page. http://gerrit.cloudera.org:8080/#/c/20538/1/tests/run-js-tests.sh File tests/run-js-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/1/tests/run-js-tests.sh@26 PS1, Line 26: NODEJS_LIB_PATH="${IMPALA_TOOLCHAIN}/node-${NODEJS_VERSION}" > It's better to add the nodejs package to Impala toolchain so that developer Sure. I will post a patch into native-toolchain. http://gerrit.cloudera.org:8080/#/c/20538/1/tests/run-js-tests.sh@47 PS1, Line 47: cd ${IMPALA_HOME}/www/scripts/ > save the current directory and restore it after running js tests. Done http://gerrit.cloudera.org:8080/#/c/20538/1/tests/run-js-tests.sh@50 PS1, Line 50: $NPM install > what's the default target directory to install? As -g parameter is not specified, the packages will be installed within the current directory. ${IMPALA_HOME}/www/scripts/tests/ http://gerrit.cloudera.org:8080/#/c/20538/1/tests/run-js-tests.sh@53 PS1, Line 53: $NPM test > Is it possible to specify the directory of testing suite? If yes, then we d Done http://gerrit.cloudera.org:8080/#/c/20538/1/www/scripts/package.json File www/scripts/package.json: http://gerrit.cloudera.org:8080/#/c/20538/1/www/scripts/package.json@14 PS1, Line 14: > nit: keep indent consistent Done -- To view, visit http://gerrit.cloudera.org:8080/20538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e Gerrit-Change-Number: 20538 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 10 Oct 2023 16:50:05 +0000 Gerrit-HasComments: Yes
