Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 )
Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI ...................................................................... Patch Set 4: (3 comments) It seems NodeJS v18 requires GLIBC 2.28 or greater. So, I switched the default NodeJS version to 16. This fixes the problems on Ubuntu 18.04. http://gerrit.cloudera.org:8080/#/c/20538/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20538/3//COMMIT_MSG@25 PS3, Line 25: values by parsing the profile. > Could you list what kinds of the failure are covered by unit-tests in this Done http://gerrit.cloudera.org:8080/#/c/20538/3/tests/run-js-tests.sh File tests/run-js-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/3/tests/run-js-tests.sh@53 PS3, Line 53: "$IMPALA_NODEJS" "$NPM" --prefix "${JS_TESTS_DIR}" install > Got following error when running this script on Ubuntu 18.04: It seems NodeJS v18 requires GLIBC 2.28 or greater. So, I switched the default NodeJS version to 16. This should resolve problems on Ubuntu 18.04. http://gerrit.cloudera.org:8080/#/c/20538/3/tests/run-js-tests.sh@53 PS3, Line 53: "$IMPALA_NODEJS" "$NPM" --prefix "${JS_TESTS_DIR}" install > Also got test failures when running this script on my Ubuntu 20.04 machine. With respect to errors on 20.04, I am failing to reproduce this errors, though even I am running on Ubuntu 20.04. I will try to reproduce these once more on another machine. -- To view, visit http://gerrit.cloudera.org:8080/20538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e Gerrit-Change-Number: 20538 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2023 16:59:31 +0000 Gerrit-HasComments: Yes
