Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 11: Code-Review+1 (3 comments) looks great! http://gerrit.cloudera.org:8080/#/c/20399/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20399/11//COMMIT_MSG@16 PS11, Line 16: that levels besides this is not clear to me - maybe "with levels besides"? http://gerrit.cloudera.org:8080/#/c/20399/11//COMMIT_MSG@18 PS11, Line 18: I don't expect any issues, but it would be nice to use the new optimization levels in actual query tests, e.g. by adding a dimension to test_queries.py similarly to ASYNC_CODEGEN https://github.com/apache/impala/blob/75797e8ec146d6118fabff27397e2e8dbcd2ebdd/tests/query_test/test_queries.py#L54 I am ok with not doing this in the current review. http://gerrit.cloudera.org:8080/#/c/20399/11/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/11/be/src/codegen/llvm-codegen.cc@1341 PS11, Line 1341: COUNTER_SET(num_opt_functions_, : counter.GetCount(InstructionCounter::TOTAL_FUNCTIONS)); : COUNTER_SET(num_opt_instructions_, counter.GetCount(InstructionCounter::TOTAL_INSTS)); : } else { : COUNTER_SET(num_opt_functions_, : counter.GetCount(InstructionCounter::TOTAL_FUNCTIONS)); : COUNTER_SET(num_opt_instructions_, counter.GetCount(InstructionCounter::TOTAL_INSTS)); : } the COUNTER_SET part seems to be the same - shouldn't we do it after the if block? -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 19 Oct 2023 12:23:11 +0000 Gerrit-HasComments: Yes
