Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/20399/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20399/11//COMMIT_MSG@16 PS11, Line 16: that levels besides > this is not clear to me - maybe "with levels besides"? I can see how that's hard to read. I've tried to clarify it. http://gerrit.cloudera.org:8080/#/c/20399/11//COMMIT_MSG@18 PS11, Line 18: > I don't expect any issues, but it would be nice to use the new optimization test_queries.py::TestQueries in exhaustive mode takes 36 minutes. Adding testing of all 5 optimization levels would make that ~3 hours. It would be useful to have more coverage somehow. http://gerrit.cloudera.org:8080/#/c/20399/11/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/11/be/src/codegen/llvm-codegen.cc@1341 PS11, Line 1341: COUNTER_SET(num_opt_functions_, : counter.GetCount(InstructionCounter::TOTAL_FUNCTIONS)); : COUNTER_SET(num_opt_instructions_, counter.GetCount(InstructionCounter::TOTAL_INSTS)); : } else { : COUNTER_SET(num_opt_functions_, : counter.GetCount(InstructionCounter::TOTAL_FUNCTIONS)); : COUNTER_SET(num_opt_instructions_, counter.GetCount(InstructionCounter::TOTAL_INSTS)); : } > the COUNTER_SET part seems to be the same - shouldn't we do it after the if Oh yup, done. -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 19 Oct 2023 17:18:22 +0000 Gerrit-HasComments: Yes
