Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )
Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1 ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG@9 PS1, Line 9: bug I assume the bug is only happening over an empty table, could you please describe a bit more how the bug looks like, what error it may throw. http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG@14 PS1, Line 14: empty nit. an empty http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1139 PS1, Line 1139: 1 How about sharing the same const mentioned in ScanNode.java? Or maybe use a separate const for this number? http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@89 PS1, Line 89: 1 How about we name a const for it? Like MIN_SCANNER_THREADS? http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@373 PS1, Line 373: 1 May use the const mentioned above. -- To view, visit http://gerrit.cloudera.org:8080/20606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97 Gerrit-Change-Number: 20606 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:58:56 +0000 Gerrit-HasComments: Yes
