Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )
Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1 ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Thanks Yida and Wenzhe! Carry +2 http://gerrit.cloudera.org:8080/#/c/20606/2/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20606/2/fe/src/main/java/org/apache/impala/planner/ScanNode.java@89 PS2, Line 89: > nit. seems MIN_NUM_SCAN_THREADS is better Done http://gerrit.cloudera.org:8080/#/c/20606/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test: http://gerrit.cloudera.org:8080/#/c/20606/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test@1 PS2, Line 1: # Regression test for IMPALA-12510: select star on empty table > nit. Can we add a comment: # Regression test for IMPALA-12510. Done -- To view, visit http://gerrit.cloudera.org:8080/20606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97 Gerrit-Change-Number: 20606 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2023 16:29:33 +0000 Gerrit-HasComments: Yes
