Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 )
Change subject: IMPALA-12493: Allow retry after failed cancel_query ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20584/3/be/src/runtime/query-driver.h File be/src/runtime/query-driver.h: http://gerrit.cloudera.org:8080/#/c/20584/3/be/src/runtime/query-driver.h@267 PS3, Line 267: True if a thread has called Finalize() nit: we need to update the comment. http://gerrit.cloudera.org:8080/#/c/20584/3/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20584/3/be/src/runtime/query-driver.cc@442 PS3, Line 442: Finalize It's not that obvious that the error is always recoverable. After checking the underlying codes, I see only the Cancel() call could return non-ok status. There are other stuffs in Finalize(), e.g. aborting transactions. We could unintentionally add new codes and return non-recoverable errors in Finalize(). Maybe it's more clean to check inflight at the begining of this method. -- To view, visit http://gerrit.cloudera.org:8080/20584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24 Gerrit-Change-Number: 20584 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2023 11:23:50 +0000 Gerrit-HasComments: Yes
