Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20623 )
Change subject: IMPALA-12516: Set HDFS limit based on memlock ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20623/1/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/20623/1/testdata/cluster/admin@249 PS1, Line 249: let DATANODE_LOCKED_MEM=$(ulimit -l)*1000 > What are some typical values for ulimit -l? Every OS I've checked has been 64 (for 64 KiB). http://gerrit.cloudera.org:8080/#/c/20623/1/testdata/cluster/admin@251 PS1, Line 251: # Provide 128MB of memory for HDFS caching. : DATANODE_LOCKED_MEM=128000 > 128KB (dfs.datanode.max.locked.memory is measured in bytes) Ack http://gerrit.cloudera.org:8080/#/c/20623/1/testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl File testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl: http://gerrit.cloudera.org:8080/#/c/20623/1/testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl@102 PS1, Line 102: <!-- Set the max cached memory to ~64kb. This must be less than ulimit -l --> > Nit: Update comment Done -- To view, visit http://gerrit.cloudera.org:8080/20623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7722ddd0c7fbd9bbd1979503952b7522b808194a Gerrit-Change-Number: 20623 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2023 20:41:21 +0000 Gerrit-HasComments: Yes
