Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20623 )

Change subject: IMPALA-12516: Set HDFS limit based on memlock
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20623/3/testdata/cluster/admin
File testdata/cluster/admin:

http://gerrit.cloudera.org:8080/#/c/20623/3/testdata/cluster/admin@247
PS3, Line 247:     if [[ "$(ulimit -l)" != "unlimited" ]]; then
> There was some feedback elsewhere that I should add raising the limit to bo
Adding code in bootstrap_system.sh makes sense, because a developer could 
deploy an ARM system and run tests locally.

I had filed IMPALA-12139 to get more test coverage with HDFS caching. It would 
involve setting this much higher (e.g. 64MB or something?). But even setting it 
to 128KB to fix the ARM issue also works.



--
To view, visit http://gerrit.cloudera.org:8080/20623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7722ddd0c7fbd9bbd1979503952b7522b808194a
Gerrit-Change-Number: 20623
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: David Rorke <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 02 Nov 2023 22:34:49 +0000
Gerrit-HasComments: Yes

Reply via email to