Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20627 )
Change subject: IMPALA-12508: Improve query option "enabled_runtime_filter_types" ...................................................................... Patch Set 2: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20627/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20627/1//COMMIT_MSG@17 PS1, Line 17: > > What do you expect the behavior to be when set to "none"? I don't think adding ENABLED_RUNTIME_FILTER_TYPES=NONE is useful when the same intention can be achieved by existing RUNTIME_FILTER_MODE=OFF. It will create confusion and the Frontend code will need to check two rather than one option to decide whether to generate runtime filter or not. I don't mind about updating the outdated code comment or docs. -- To view, visit http://gerrit.cloudera.org:8080/20627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecff7c655e273712d851d9ce94ef5713e579aa72 Gerrit-Change-Number: 20627 Gerrit-PatchSet: 2 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2023 03:48:11 +0000 Gerrit-HasComments: Yes
