Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20627 )
Change subject: IMPALA-12508: Update query option "enabled_runtime_filter_types" comments ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks for making the change. I just have one nit. http://gerrit.cloudera.org:8080/#/c/20627/3/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20627/3/common/thrift/ImpalaService.thrift@540 PS3, Line 540: // Default is [BLOOM, MIN_MAX]. nit: Based on comment at https://github.com/apache/impala/blob/248060528abd7fb5425f519ee1608598ed2d3ac3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java#L1088-L1093 and reading the code there, few more detail can be added here like this: "Depending on the scan node type, Planner can schedule compatible runtime filter type as follows. - Kudu scan: BLOOM, MIN_MAX - Hdfs scan on Parquet file: BLOOM, MIN_MAX - Hdfs scan on ORC file: BLOOM, IN_LIST - Hdfs scan on other kind of file: BLOOM, IN_LIST" -- To view, visit http://gerrit.cloudera.org:8080/20627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecff7c655e273712d851d9ce94ef5713e579aa72 Gerrit-Change-Number: 20627 Gerrit-PatchSet: 3 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2023 15:40:01 +0000 Gerrit-HasComments: Yes
