Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20617 )
Change subject: IMPALA-12515: Build modules for extra pythons ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20617/4/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20617/4/shell/CMakeLists.txt@35 PS4, Line 35: if (NOT $ENV{IMPALA_SYSTEM_PYTHON3} STREQUAL "") > This doesn't work with make_shell_tarball.sh, which infers venvs from the E Updated so CMake will error if system pythons aren't binaries named "python2" and "python3". You can use any path, but the binary name is expected to match. Build systems can adapt to this by creating a symlink if they need to do something unusual. -- To view, visit http://gerrit.cloudera.org:8080/20617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13720a9e3c50f348bef41f5e91f810204e416f13 Gerrit-Change-Number: 20617 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2023 17:46:50 +0000 Gerrit-HasComments: Yes
