Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20617 )
Change subject: IMPALA-12515: Build modules for extra pythons ...................................................................... Patch Set 5: (1 comment) One tiny thing I didn't notice the first time around http://gerrit.cloudera.org:8080/#/c/20617/5/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20617/5/shell/CMakeLists.txt@52 PS5, Line 52: set(VENV "${VENV_LOC}/${PYTHON_NAME}") Nit: What do you think about tacking on a "_venv" to the directory name? -- To view, visit http://gerrit.cloudera.org:8080/20617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13720a9e3c50f348bef41f5e91f810204e416f13 Gerrit-Change-Number: 20617 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:53:31 +0000 Gerrit-HasComments: Yes
