Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20636 )
Change subject: IMPALA-12376: DataSourceScanNode drop some returned rows ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20636/1/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20636/1/tests/custom_cluster/test_ext_data_sources.py@49 PS1, Line 49: @SkipIf.not_hdfs Would be good to also add a test where the data returned by external table is less than the data_source_batch_size value. http://gerrit.cloudera.org:8080/#/c/20636/1/tests/custom_cluster/test_ext_data_sources.py@49 PS1, Line 49: Why are we skipping all these tests for non hdfs? -- To view, visit http://gerrit.cloudera.org:8080/20636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978d0a65faa63a47ec86a0127c0bee8dfb79530b Gerrit-Change-Number: 20636 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 13:32:23 +0000 Gerrit-HasComments: Yes
