Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20636 )
Change subject: IMPALA-12376: DataSourceScanNode drop some returned rows ...................................................................... IMPALA-12376: DataSourceScanNode drop some returned rows DataSourceScanNode does not handle eos properly in function DataSourceScanNode::GetNext(). Rows, which are returned from external data source, could be dropped if data_source_batch_size is set with value which is greater than default value 1024. Testing: - Added end-to-end test with data_source_batch_size as 2048. The test failed without fixing, passed with fixing. Also added test with data_source_batch_size as 512. - Passed core tests. Change-Id: I978d0a65faa63a47ec86a0127c0bee8dfb79530b --- M be/src/exec/data-source-scan-node.cc M testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test M tests/custom_cluster/test_ext_data_sources.py 3 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/20636/2 -- To view, visit http://gerrit.cloudera.org:8080/20636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I978d0a65faa63a47ec86a0127c0bee8dfb79530b Gerrit-Change-Number: 20636 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
