Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20689 )
Change subject: IMPALA-12550: Fix flaky test test_statestored_auto_failover_with_disabling_network ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/20689/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20689/2//COMMIT_MSG@12 PS2, Line 12: minutes to respond to the handshake requests from standby statestore. > You added an extra "n". fixed http://gerrit.cloudera.org:8080/#/c/20689/2//COMMIT_MSG@12 PS2, Line 12: minutes to respond to the handshake requests from standby statestore. > nit: "to respond to the" fixed http://gerrit.cloudera.org:8080/#/c/20689/2//COMMIT_MSG@14 PS2, Line 14: This patch fixes the issue by not holding mutex ha_lock_ when sending > nit: "fixes" fixed http://gerrit.cloudera.org:8080/#/c/20689/2/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/20689/2/be/src/statestore/statestore.cc@720 PS2, Line 720: num_received_heartbeat_in_active_ = 0; > We reset this whenever `is_active_` is set to true, right? Might be worth a added a comment in statestore.h http://gerrit.cloudera.org:8080/#/c/20689/2/be/src/statestore/statestore.cc@2128 PS2, Line 2128: lock_guard<mutex> l(ha_lock_); > Why does this require a lock? Because it's accessing peer_statestore_id_? Yes, that variable could be changed by other threads. -- To view, visit http://gerrit.cloudera.org:8080/20689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515bbaaddfb4bf9bd2a39414cd6e3e4590dfbfb1 Gerrit-Change-Number: 20689 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 Nov 2023 18:27:09 +0000 Gerrit-HasComments: Yes
