Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20689 )
Change subject: IMPALA-12550: Fix flaky test test_statestored_auto_failover_with_disabling_network ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20689/4/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/20689/4/be/src/statestore/statestore.cc@211 PS4, Line 211: // If statestore instance in active state receives more than 10 heartbeats from its peer, : // enter recovery mode to re-negotiate role with its peer. > By default, how long is it in terms of second? 10 second? Updated comments http://gerrit.cloudera.org:8080/#/c/20689/4/be/src/statestore/statestore.cc@1976 PS4, Line 1976: LOG(WARNING) << "Enter HA recovery mode."; > nit: Not asking in this patch, but I think it is worth to break this functi Good suggestion. Will change in the future. Added TODO here http://gerrit.cloudera.org:8080/#/c/20689/4/be/src/statestore/statestore.cc@2006 PS4, Line 2006: in_ha_recovery_mode_metric_->SetValue(in_recovery_mode_); : peer_statestore_id_ = response.dst_statestore_id; > nit: Is it possible to also print how long this statestored stays in recove Good suggestion. Added elapsed time in the log message. -- To view, visit http://gerrit.cloudera.org:8080/20689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515bbaaddfb4bf9bd2a39414cd6e3e4590dfbfb1 Gerrit-Change-Number: 20689 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 Nov 2023 20:29:53 +0000 Gerrit-HasComments: Yes
