Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: Implement pre-allocation in Section Memory Manager ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20692/1/be/src/codegen/mcjit-mem-mgr.cc File be/src/codegen/mcjit-mem-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20692/1/be/src/codegen/mcjit-mem-mgr.cc@18 PS1, Line 18: // Based on https://github.com/llvm/llvm-project/blob/llvmorg-5.0.1/llvm/lib/ExecutionEngine/SectionMemoryManager.cpp line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/20692/1/be/src/codegen/mcjit-mem-mgr.cc@133 PS1, Line 133: PendingMB = sys::MemoryBlock(PendingMB.base(), Addr + Size - (uintptr_t)PendingMB.base()); line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 10 Nov 2023 09:04:45 +0000 Gerrit-HasComments: Yes
