Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in Section Memory Manager ...................................................................... Patch Set 4: (4 comments) Just very high level comments so far, I don't understand the actual issue/fix yet. It would be easier to digest the change if the copied and changed code would be separated somehow. http://gerrit.cloudera.org:8080/#/c/20692/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20692/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-11542: Implement pre-allocation in Section Memory Manager Can you add "llvm" to the title to make the scope clearer? http://gerrit.cloudera.org:8080/#/c/20692/4//COMMIT_MSG@12 PS4, Line 12: Implements up-front allocation for the LLVM Memory Manager to avoid Can you mention that this is an LLVM issue and that the Jira contains more information? http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.h File be/src/codegen/mcjit-mem-mgr.h: http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.h@83 PS4, Line 83: struct FreeMemBlock { Can you mention that these come from https://github.com/llvm/llvm-project/blob/llvmorg-5.0.1/llvm/include/llvm/ExecutionEngine/SectionMemoryManager.h ? http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc File be/src/codegen/mcjit-mem-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc@93 PS4, Line 93: uint8_t *ImpalaMCJITMemoryManager::allocateDataSection(uintptr_t Size, unsigned Alignment, : unsigned SectionID, StringRef SectionName, bool IsReadOnly) { : if (IsReadOnly) : return allocateSection(RODataMem, Size, Alignment); : return allocateSection(RWDataMem, Size, Alignment); : } : : uint8_t *ImpalaMCJITMemoryManager::allocateCodeSection(uintptr_t Size, unsigned Alignment, : unsigned SectionID, StringRef SectionName) { : return allocateSection(CodeMem, Size, Alignment); : } : : uint8_t *ImpalaMCJITMemoryManager::allocateSection(MemoryGroup &MemGroup, Can you mark somehow which functions is just a copy from llvm, and which one has changes? I still want to understand the old code, but the new code needs more attention. -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Nov 2023 10:59:34 +0000 Gerrit-HasComments: Yes
