Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 )
Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time ...................................................................... Patch Set 4: (2 comments) Thanks for the review, I will add some unit-test cases next week. http://gerrit.cloudera.org:8080/#/c/20681/4/be/src/exec/kudu/kudu-util.h File be/src/exec/kudu/kudu-util.h: http://gerrit.cloudera.org:8080/#/c/20681/4/be/src/exec/kudu/kudu-util.h@76 PS4, Line 76: local_tz > should we set default value as UTCPTR? Done http://gerrit.cloudera.org:8080/#/c/20681/4/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20681/4/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@485 PS4, Line 485: String functionName = analyzer.getQueryOptions().isConvert_kudu_utc_timestamps() ? : "to_unix_micros" : "utc_to_unix_micros"; > isConvert_kudu_utc_timestamps() should apply on only Kudu node. According to the comments and related code of isTimestampTruncation, when isTimestampTruncation is true, isConvert_kudu_utc_timestamps() already only be applied to Kudu scan nodes now. However, perhaps we can rename isTimestampTruncation to make it clearer, for example, how about isKuduTimestampTruncation? -- To view, visit http://gerrit.cloudera.org:8080/20681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a1e7a13e617cc18deef14289cf9b958588397d3 Gerrit-Change-Number: 20681 Gerrit-PatchSet: 4 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 10 Nov 2023 10:56:18 +0000 Gerrit-HasComments: Yes
