Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 )
Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time ...................................................................... Patch Set 4: (1 comment) > There is another related patch https://gerrit.cloudera.org/#/c/20438/ which > was submitted two months ago, but did not make progress. We could abandon > that patch after this patch is merged, right? Yes, I saw it. Both patches address the same issue, but it seems like that patch doesn't have any further updates. http://gerrit.cloudera.org:8080/#/c/20681/4/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20681/4/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@485 PS4, Line 485: String functionName = analyzer.getQueryOptions().isConvert_kudu_utc_timestamps() ? : "to_unix_micros" : "utc_to_unix_micros"; > Don't need to rename the variable. Add a comment before this line "The filt Done -- To view, visit http://gerrit.cloudera.org:8080/20681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a1e7a13e617cc18deef14289cf9b958588397d3 Gerrit-Change-Number: 20681 Gerrit-PatchSet: 4 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Wed, 15 Nov 2023 12:13:21 +0000 Gerrit-HasComments: Yes
