Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 )
Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time ...................................................................... Patch Set 5: (2 comments) Thank you for your suggestion! I agree with your point that using a timestamp column as a join key is indeed rare, and thus, making extensive modifications for this might not be worthwhile. Now that everything looks complete except for adding tests, I'll add some tests asap. http://gerrit.cloudera.org:8080/#/c/20681/5/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/20681/5/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@573 PS5, Line 573: kuduPredicate = KuduPredicate.newComparisonPredicate(column, op, unixMicros); > I agree with the solution. EQ predicates could be turned to an in-list if i Done http://gerrit.cloudera.org:8080/#/c/20681/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20681/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@485 PS5, Line 485: String functionName = analyzer.getQueryOptions().isConvert_kudu_utc_timestamps() ? : "to_unix_micros" : "utc_to_unix_micros"; : Expr toUnixTimeExpr = : new FunctionCallExpr(functionName, Lists.newArrayList(srcExpr)); > I think that it is ok to disable bloom filters in case isConvert_kudu_utc_t Done -- To view, visit http://gerrit.cloudera.org:8080/20681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a1e7a13e617cc18deef14289cf9b958588397d3 Gerrit-Change-Number: 20681 Gerrit-PatchSet: 5 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 09:51:52 +0000 Gerrit-HasComments: Yes
