Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20673 )
Change subject: IMPALA-12486: Add catalog metrics for metadata loading ...................................................................... Patch Set 2: (6 comments) A few nits and questions only http://gerrit.cloudera.org:8080/#/c/20673/2/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/20673/2/be/src/catalog/catalog-server.h@172 PS2, Line 172: asynchorously Spelling: asynchronously http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/JniCatalog.thrift@1041 PS2, Line 1041: 5: optional i64 catalog_num_file_metadata_loading_tasks Why is this not i32 as well? http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/JniCatalog.thrift@1054 PS2, Line 1054: 14: optional i32 catalog_num_hms_clients_in_used Nit: "catalog_num_hms_clients_in_use" http://gerrit.cloudera.org:8080/#/c/20673/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/20673/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@110 PS2, Line 110: TOTAL_TASKS.incrementAndGet(); Add comment explaining when this is decremented (in load() I think, which may be overridden) http://gerrit.cloudera.org:8080/#/c/20673/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@236 PS2, Line 236: TOTAL_TASKS.decrementAndGet(); Maybe neater if this is in a finally block? Then the other decrementAndGet() can be removed? http://gerrit.cloudera.org:8080/#/c/20673/2/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java: http://gerrit.cloudera.org:8080/#/c/20673/2/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java@54 PS2, Line 54: numHmsClientsInUsed_ Nit: numHmsClientsInUse_ -- To view, visit http://gerrit.cloudera.org:8080/20673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icef7b123bdcb0f5b8572635eeaacd8294990f9ba Gerrit-Change-Number: 20673 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 17:48:40 +0000 Gerrit-HasComments: Yes
