Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20673 )
Change subject: IMPALA-12486: Add catalog metrics for metadata loading ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/metrics.json@350 PS2, Line 350: catalog- > We also have some existing metrics that have "catalog." prefix: Thanks for making the change! New one looks god to me. http://gerrit.cloudera.org:8080/#/c/20673/4/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java: http://gerrit.cloudera.org:8080/#/c/20673/4/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java@138 PS4, Line 138: decrementAndGet nit: is it worth to add Precondition that decrementAndGet() never return negative number, here and other new AtomicInteger? http://gerrit.cloudera.org:8080/#/c/20673/4/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java@236 PS4, Line 236: _ nit: Underscore can be removed? -- To view, visit http://gerrit.cloudera.org:8080/20673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icef7b123bdcb0f5b8572635eeaacd8294990f9ba Gerrit-Change-Number: 20673 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 23:17:29 +0000 Gerrit-HasComments: Yes
